Issue95 Interactor for Volunteers#reactivate #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jconley88
force-pushed
the
issue95_reactivate
branch
from
1b8db7f to
c73aa9a
Compare
So I think most of the authorization stuff will be handled by CanCanCan (see #96). I'm not sure how I feel about pulling auth into the interactors, but I think I'd lean toward keeping it in the controllers, at least until we have more interactors built out and have a larger understanding of how we would best build a framework like this that works for all of them. |
jconley88
force-pushed
the
issue95_reactivate
branch
from
c73aa9a to
0a257f3
Compare
|
Yeah, that makes more sense. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pull Volunteers#reactivate logic into an Interactor.
Details
I developed an Authorize module that extends (monkey patches, 🙈) the Interactor module. Good idea? Bad idea?